feat(Settings): add secure environment editor in localhost:3001 #854
Merged
Lightheartdevs merged 2 commits intoLight-Heart-Labs:mainfrom Apr 8, 2026
Merged
Conversation
gabsprogrammer
changed the title
Contributor
Author
|
Lightheartdevs
approved these changes
Apr 8, 2026
Collaborator
Lightheartdevs
left a comment
Lightheartdevs
left a comment
There was a problem hiding this comment.
APPROVE. Security model is solid: secrets never sent to browser, endpoints authenticated, raw mode rejected, unknown keys rejected, atomic writes with backup, 30 security tests. One defense-in-depth gap: no newline/null-byte rejection in submitted values (not exploitable in current architecture — Docker Compose and dotenv treat as literal strings). Will fix in a follow-up PR.
Lightheartdevs
added a commit
that referenced
this pull request
Apr 8, 2026
Adds validation in _serialize_form_values to reject values containing \n, \r, or \0. Prevents .env injection where a value like "3010\nINJECTED_KEY=malicious" could write an extra line to .env. Not exploitable in the current architecture (Docker Compose and Python dotenv treat values as literal strings), but closes a defense-in-depth gap identified during the #854 security audit. Adds 2 tests: newline injection rejected (400), null byte rejected (400). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Lightheartdevs
added a commit
that referenced
this pull request
Apr 8, 2026
Adds validation in _serialize_form_values to reject values containing \n, \r, or \0. Prevents .env injection where a value like "3010\nINJECTED_KEY=malicious" could write an extra line to .env. Not exploitable in the current architecture (Docker Compose and Python dotenv treat values as literal strings), but closes a defense-in-depth gap identified during the #854 security audit. Adds 2 tests: newline injection rejected (400), null byte rejected (400). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.